Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13351#discussion_r65073217
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -686,9 +686,22 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
val stream = new java.io.PrintStream(buffer, true, "UTF-8")
// scalastyle:off println
- stream.println("test circular test circular test circular test
circular test circular")
+ stream.print("test circular\n test circular\r test circular\n test
circular\r test circular\n")
// scalastyle:on println
- assert(buffer.toString === "t circular test circular\n")
+ assert(buffer.toString === " circular\r test circular\n")
+ }
+
+ test("circular buffer: if the buffer isn't full, print only the contents
written") {
+ val buffer = new CircularBuffer(25)
+ val stream = new java.io.PrintStream(buffer, true, "UTF-8")
--- End diff --
Nit, but unless I miss a reason this can't be imported, it can just be
imported
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
