GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/1811
[Spark QA] [WIP] Include commit hash in Spark QA messages
There is currently no JIRA issue for this PR, but you can find the
[motivating discussion
here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9tx+exywarm7pncvm8apqcwc-eslb...@mail.gmail.com%3E).
This is a work in progress.
The goal of this PR (and related ones to come) is to include useful detail
in Spark QA's messages that are intended to make a committer's job easier to do.
Since this work depends on Jenkins, I cannot test this locally. Hence, I
will be iterating via this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1811.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1811
----
commit 75ad55211397345e5192a19513d478b913028506
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:13:21Z
make check output style consistent
The RAT and PEP8 checks donât print a blank line after successful runs.
The scalastyle check shouldnât either.
commit 61c07b911b033b0356326397a6b7168dc94e6632
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:15:49Z
[SPARK-2627] add Python linter
This guy just runs the pep8 utility on all code in the python
directory, minus cloudpickle, which is a 3rd-party library.
commit 12440faa1a0a8b7eb41c5778ea49c360cb0de532
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:23:06Z
[SPARK-2627] add Scala linter
This guy just calls scalastyle.
commit 0541ebb5f30973aa54157256b4e43decfa9de8ba
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:23:30Z
[SPARK-2627] call Python linter from run-tests
commit 723ed39fb5067e3827a3e1f5434fb111b8e498cc
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:24:00Z
always delete the report file
commit beaa9ac5154ec13c0067ada286327a615022bd59
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T04:05:33Z
[SPARK-2627] fail check on non-zero status
commit a31ccc442fe0fa220eeac5c118d3045bb3d83142
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T04:06:18Z
[SPARK-2627] miscellaneous PEP 8 fixes
Mostly done using autopep8, plus some hand fixes.
commit 9a66cb0391794f18733cf54cfe2a337a75aeefb4
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T07:02:30Z
resolving merge conflicts
*fingers crossed*
I admit Iâm not exactly sure how this works⦠Letâs see if I did the
right thing.
commit 9c01d4cffc33fc98182f9202b8d282bdf8a3bf25
Author: nchammas <[email protected]>
Date: 2014-08-03T07:08:15Z
Merge pull request #1 from apache/master
merge upstream changes
commit fe57ed080e0dcd4e9ca624360c91a3d96086460a
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T07:09:52Z
removing merge conflict backups
commit 6f4900b64ac3f6500748f5d0f849e20567976879
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T07:17:24Z
[SPARK-2627] more misc PEP 8 fixes
commit 21da538b432a165c2c4ba6eb60ff74b7ed5ab5b4
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T07:25:45Z
[SPARK-2627] it's PEP 8, not PEP8
Minor, I know.
commit a1ce7ae405754600cf92828bf0db3271c46e4961
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T17:47:50Z
[SPARK-2627] space out test report sections
Everything looks cramped and itâs hard to tell at a glance where
sections begin. Adding a blank line between sections should fix that.
commit dffb5ddc465b9e0b1220b5713c17ff4aaf9b7dbc
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T18:11:57Z
[SPARK-2627] download pep8 at runtime
See the discussion here:
https://github.com/apache/spark/pull/1744#issuecomment-50982162
Get the pep8 utility at runtime so that itâs not required to be
installed on the build server.
commit d0a83b91c0b192451f0289e62f3448df54c48562
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-03T18:44:40Z
[SPARK-2627] check that pep8 downloaded fine
Donât just assume curl got the file alright. Check and exit properly if
there were any problems.
commit aa5b4b50047573123db9f5b5c47989330a268846
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T20:57:42Z
[SPARK-2627] follow Spark bash style for if blocks
âthenâ goes on the same line as the opening âifâ.
commit 9da347f75c1387e6fce47456735bfc8f19a7b5a6
Author: nchammas <[email protected]>
Date: 2014-08-04T21:18:26Z
Merge pull request #2 from apache/master
merge upstream changes
commit bfb9f9f12fa04910ebc5f53e6a5538d8341139b8
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T21:20:14Z
[SPARK-2627] keep up with the PEP 8 fixes
commit b09fae2af51439375c56776b567ef561c44a31d1
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T21:32:18Z
don't wrap comments unnecessarily
commit 44e3e56e14ef9d4edd2849623577c1e9282f81ed
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T23:23:55Z
[SPARK-2627] use tox.ini to exclude files
No need to exclude files in the call to pep8. The tool references
tox.ini for config information, so we should use that.
commit 91b7584a5c43700bd559ed29868af4fba97f26ea
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T23:25:11Z
[SPARK-2627] undo unnecessary line breaks
âUndoâ unnecessary line breaks introduced by accident when I called
autopep8 on the whole Python directory without setting the max line
length to 100. (autopep8 defaults to 79.)
commit 7b4750eed89221d54c029618712d2e8862fe2110
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T23:31:13Z
merge upstream changes
commit 6db9a444eeef9b723a69b3d895df871b45b6fa20
Author: nchammas <[email protected]>
Date: 2014-08-04T23:31:36Z
Merge pull request #3 from apache/master
[SPARK-1687] [PySpark] fix unit tests related to pickable namedtuple
commit bf3094281077c9875a277929b4703525306d7bf0
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-04T23:38:30Z
[SPARK-2627] PEP8: comment spacing
PEP 8 is the beeâs knees.
commit 0e0245f2356bba84a4c7df90fcbcd7dc51448ede
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-05T00:08:17Z
[SPARK-2627] undo erroneous whitespace fixes
commit 1db5314eeade5c996b70dbc3685bbe06a0bbd41a
Author: nchammas <[email protected]>
Date: 2014-08-05T21:50:40Z
Merge pull request #4 from apache/master
merge upstream changes
commit 983d963a7600ce61caa230984461e91b343b0d33
Author: nchammas <[email protected]>
Date: 2014-08-06T15:40:02Z
Merge pull request #5 from apache/master
merge upstream changes
commit 274b2384bb28f03eb034686e6e730e73af3ffaf3
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-06T18:29:55Z
[SPARK-2627] [PySpark] minor indentation changes
commit b214c6587897c7f016b900b9411d648babdb7283
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-06T21:09:06Z
[Experimental] Include commit hash in QA message
commit 8bef87dd589a4700b1c4ab2589064794c78db855
Author: nchammas <[email protected]>
Date: 2014-08-06T21:11:16Z
Merge pull request #6 from apache/master
merge upstream changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
