Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13410#discussion_r65190848
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -114,7 +112,7 @@ private[feature] trait CountVectorizerParams extends
Params with HasInputCol wit
/** @group getParam */
def getBinary: Boolean = $(binary)
- setDefault(binary -> false)
+ setDefault(vocabSize -> (1 << 18), minDF -> 1.0, minTF -> 1.0, binary ->
false)
--- End diff --
Some params' default values setting method was placed in
```CountVectorizer``` estimator and can not be shared by both estimator and
model. Here we put them together and in ```CountVectorizerParams```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
