Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13382#discussion_r65263926
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java
---
@@ -48,7 +48,7 @@
private final File file;
private final BlockId blockId;
private final int numRecordsToWrite;
- private DiskBlockObjectWriter writer;
+ private final DiskBlockObjectWriter writer;
--- End diff --
I think that this was purposely non-final so that we can null it out in
order to allow the writer to be garbage collected as soon as `close()` is
called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
