Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13415#discussion_r65280546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
---
@@ -50,6 +50,17 @@ object ParserUtils {
}
}
+ /** Check if duplicate exist in a set of column names. */
+ def checkDuplicateNames[T](colNames: Seq[String], ctx:
ParserRuleContext): Unit = {
+ if (colNames.length != colNames.distinct.length) {
+ val duplicateColumns = colNames.groupBy(identity).collect {
+ case (x, ys) if ys.length > 1 => "\"" + x + "\""
+ }
+ throw new ParseException(s"Column repeated in partitioning column(s)
or duplicate column " +
+ s"name key in the table definition:
${duplicateColumns.mkString("[", ",", "]")}", ctx)
--- End diff --
@andrewor14 Let me know if you want me to split it into two separate error
messages. That means, we will have an extra checking condition with an extra
parameter. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
