Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13335#discussion_r65282727
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompositeOffset.scala
 ---
    @@ -67,6 +67,15 @@ case class CompositeOffset(offsets: Seq[Option[Offset]]) 
extends Offset {
     
       override def toString: String =
         offsets.map(_.map(_.toString).getOrElse("-")).mkString("[", ", ", "]")
    +
    +  override def equals(other: Any): Boolean = other match {
    +    case that: CompositeOffset => offsets != null && 
offsets.sameElements(that.offsets)
    --- End diff --
    
    Need to redefine `equals` and `hashCode` as `offsets` is an array


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to