Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/1814#discussion_r15908318
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala ---
@@ -35,38 +35,47 @@ import org.apache.spark.rdd.RDD
* @param withStd True by default. Scales the data to unit standard
deviation.
*/
@Experimental
-class StandardScaler(withMean: Boolean, withStd: Boolean) extends
VectorTransformer {
+class StandardScaler(withMean: Boolean, withStd: Boolean) {
--- End diff --
This class is only used for keeping the state of withMean, and withStd, is
it possible to move those states to fit function by overloading, and make it as
object?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
