GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13434
[SPARK-15322][SQL][FOLLOWUP] Use the new long accumulator for old int
accumulators.
## What changes were proposed in this pull request?
This PR corrects the last cases for using old accumulators.
This does not change some old accumulator usages below:
- `ImplicitSuite.scala` - Tests dedicated to old accumulator, for implicits
with `AccumulatorParam`
- `AccumulatorSuite.scala` - Tests dedicated to old accumulator
- `JavaSparkContext.scala` - For supporting old accumulators for Java API.
- `debug.package.scala` - Usage with `HashSet[String]`. Currently, it seems
no implementation for this. I might be able to write a anonymous class for this
but I didn't because I think it is not worth writing a lot only for this.
- `SQLMetricsSuite` - This uses the old accumulator for checking type
boxing. It seems new accumulator does not require type boxing for this case
whereas the old one requires (due to the use of generic).
## How was this patch tested?
Existing tests cover this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark accum
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13434.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13434
----
commit d9cf1cfb1edcc5b4829ed29468bcdd0189aec095
Author: hyukjinkwon <[email protected]>
Date: 2016-06-01T05:36:10Z
Use new long accumulator instead of old integer accumulator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
