Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13433#discussion_r65430073
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -222,6 +225,8 @@ private[sql] case class InMemoryTableScanExec(
@transient relation: InMemoryRelation)
extends LeafExecNode {
+ override protected def innerChildren: Seq[TreeNode[_]] = Seq(relation)
++ super.innerChildren
--- End diff --
ok seems this is the only special case, how about we add a comment to
explain why we call `super.innerChildren` here? e.g. There are expressions
inside this operator and may contain subquery expression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
