GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/13454
[SPARK-15714] Fix flaky o.a.s.scheduler.BlacklistIntegrationSuite
## What changes were proposed in this pull request?
BlacklistIntegrationSuite (introduced by SPARK-10372) is a bit flaky
because of some race conditions:
1. Failed jobs might have non-empty results, because the resultHandler will
be invoked for successful tasks (if there are task successes before failures)
2. taskScheduler.taskIdToTaskSetManager must be protected by a lock on
taskScheduler
(1) has failed a handful of jenkins builds recently. I don't think I've
seen (2) in jenkins, but I've run into with some uncommitted tests I'm working
on where there are lots more tasks.
While I was in there, I also made an unrelated fix to `runningTasks`in the
test framework -- there was a pointless `O(n)` operation to remove completed
tasks, could be `O(1)`.
## How was this patch tested?
I modified the o.a.s.scheduler.BlacklistIntegrationSuite to have it run the
tests 1k times on my laptop. It failed 11 times before this change, and none
with it. (Pretty sure all the failures were problem (1), though I didn't check
all of them).
Also the full suite of tests via jenkins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/squito/spark SPARK-15714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13454
----
commit 33b37391c9ea33cc587f48ae7a2e123941b18b7f
Author: Imran Rashid <[email protected]>
Date: 2016-06-01T21:32:14Z
do not check if results is empty on a failure -- instead just make sure we
got a failure exception
commit ccb6c2090567e863bf572a5cfbe55a8d3a16d225
Author: Imran Rashid <[email protected]>
Date: 2016-06-01T21:51:12Z
taskScheduler.taskIdToTaskSetManager must be protected by taskScheduler;
cleanup runningTasks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
