Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13394#discussion_r65483594
  
    --- Diff: R/pkg/R/stats.R ---
    @@ -135,13 +136,13 @@ setMethod("freqItems", signature(x = 
"SparkDataFrame", cols = "character"),
     #' Calculates the approximate quantiles of a numerical column of a 
SparkDataFrame.
     #'
     #' The result of this algorithm has the following deterministic bound:
    -#' If the SparkDataFrame has N elements and if we request the quantile at 
probability `p` up to
    -#' error `err`, then the algorithm will return a sample `x` from the 
SparkDataFrame so that the
    -#' *exact* rank of `x` is close to (p * N). More precisely,
    -#'   floor((p - err) * N) <= rank(x) <= ceil((p + err) * N).
    -#' This method implements a variation of the Greenwald-Khanna algorithm 
(with some speed
    -#' optimizations). The algorithm was first present in 
[[http://dx.doi.org/10.1145/375663.375670
    -#' Space-efficient Online Computation of Quantile Summaries]] by Greenwald 
and Khanna.
    +#' If the SparkDataFrame has N elements and if we request the quantile at 
probability \strong{p} up
    --- End diff --
    
    I think it would be great to leave this out and I will fix it in #13109? 
what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to