Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13459#discussion_r65575316
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
    @@ -166,21 +207,33 @@ object DatasetBenchmark {
         val numChains = 10
     
         val benchmark = backToBackMap(spark, numRows, numChains)
    -    val benchmark2 = backToBackFilter(spark, numRows, numChains)
    -    val benchmark3 = aggregate(spark, numRows)
    +    val benchmark2 = backToBackMapPrimitive(spark, numRows, numChains)
    +    val benchmark3 = backToBackFilter(spark, numRows, numChains)
    +    val benchmark4 = aggregate(spark, numRows)
     
         /*
    -    Java HotSpot(TM) 64-Bit Server VM 1.8.0_60-b27 on Mac OS X 10.11.4
    -    Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz
    --- End diff --
    
    since the hardware is different, I think you should rerun the whole 
benchmark and update the result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to