Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65608399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <:
TreeNode[BaseType]] extends Product {
private lazy val allChildren: Set[TreeNode[_]] = (children ++
innerChildren).toSet[TreeNode[_]]
/** Returns a string representing the arguments to this node, minus any
children */
- def argString: String = productIterator.flatMap {
+ def argString: String = stringArgs.flatMap {
case tn: TreeNode[_] if allChildren.contains(tn) => Nil
case Some(tn: TreeNode[_]) if allChildren.contains(tn) => Nil
- case tn: TreeNode[_] => s"${tn.simpleString}" :: Nil
- case seq: Seq[BaseType] if seq.toSet.subsetOf(children.toSet) => Nil
- case seq: Seq[_] => seq.mkString("[", ",", "]") :: Nil
- case set: Set[_] => set.mkString("{", ",", "}") :: Nil
+ case tn: TreeNode[_] => tn.simpleString :: Nil
+ case seq: Seq[Any] if
seq.toSet.subsetOf(allChildren.asInstanceOf[Set[Any]]) => Nil
--- End diff --
yea I know type-erase happens here, but if we really wanna make things
clear here, we should use `Seq[_]`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
