Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13476#discussion_r65656594
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -695,10 +695,6 @@ setGeneric("desc", function(x) { 
standardGeneric("desc") })
     
     #' @rdname column
     #' @export
    -setGeneric("endsWith", function(x, ...) { standardGeneric("endsWith") })
    --- End diff --
    
    you shouldn't need to remove it - I think if they are updated to match the 
signature of the existing generic (in newer R 3.3.0) it should work both in the 
case of R 3.3.0 and R 3.2.0.
    With regards to the comment on R version check - it should not be necessary 
also.
    @shivaram 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to