Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13469#discussion_r65746393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -519,7 +519,7 @@ case class CreateExternalRow(children: Seq[Expression],
schema: StructType)
val code = s"""
$values = new Object[${children.size}];
$childrenCode
- final ${classOf[Row].getName} ${ev.value} = new $rowClass($values,
this.$schemaField);
+ final ${classOf[Row].getName} ${ev.value} = new $rowClass($values,
$schemaField);
--- End diff --
Dropping `this` is safer, as the code maybe put in an inner class.
We generate names by a unique id and it's impossible to get name collision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
