Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13505#discussion_r65795007
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala 
---
    @@ -296,7 +296,7 @@ abstract class QueryPlan[PlanType <: 
QueryPlan[PlanType]] extends TreeNode[PlanT
       /**
        * All the attributes that are used for this plan.
        */
    -  lazy val allAttributes: Seq[Attribute] = children.flatMap(_.output)
    +  lazy val allAttributes: AttributeSeq = children.flatMap(_.output)
    --- End diff --
    
    We should probably construct the AttributeSeq outside of the loop in the 
various projection operators, too, although that doesn't appear to be as 
serious a bottleneck yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to