Github user wangyang1992 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13522#discussion_r65898385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -554,14 +561,19 @@ case class FromUnixTime(sec: Expression, format:
Expression)
boolean ${ev.isNull} = true;
${ctx.javaType(dataType)} ${ev.value} =
${ctx.defaultValue(dataType)};""")
} else {
+ val sdfTerm = ctx.freshName("formatter")
--- End diff --
This is trivial but why use a different variable name here from the above
one? (which is called "formatter")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
