Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/13338#discussion_r65978425
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2262,21 +2262,39 @@ private[spark] object Utils extends Logging {
}
/**
- * Return whether dynamic allocation is enabled in the given conf
- * Dynamic allocation and explicitly setting the number of executors are
inherently
- * incompatible. In environments where dynamic allocation is turned on
by default,
- * the latter should override the former (SPARK-9092).
+ * Return whether dynamic allocation is enabled in the given conf.
*/
def isDynamicAllocationEnabled(conf: SparkConf): Boolean = {
- val numExecutor = conf.getInt("spark.executor.instances", 0)
val dynamicAllocationEnabled =
conf.getBoolean("spark.dynamicAllocation.enabled", false)
- if (numExecutor != 0 && dynamicAllocationEnabled) {
- logWarning("Dynamic Allocation and num executors both set, thus
dynamic allocation disabled.")
- }
- numExecutor == 0 && dynamicAllocationEnabled &&
+ dynamicAllocationEnabled &&
(!isLocalMaster(conf) ||
conf.getBoolean("spark.dynamicAllocation.testing", false))
}
+ /**
+ * Return the minimum number of executors for dynamic allocation.
+ */
+ def getDynamicAllocationMinExecutors(conf: SparkConf): Int = {
+ conf.getInt("spark.dynamicAllocation.minExecutors", 0)
+ }
+
+ /**
+ * Return the maximum number of executors for dynamic allocation.
+ */
+ def getDynamicAllocationMaxExecutors(conf: SparkConf): Int = {
+ conf.getInt("spark.dynamicAllocation.maxExecutors", Integer.MAX_VALUE)
+ }
+
+ /**
+ * Return the initial number of executors for dynamic allocation.
+ */
+ def getDynamicAllocationInitialExecutors(conf: SparkConf): Int = {
+ math.max(
+ math.max(
+ conf.getInt("spark.dynamicAllocation.initialExecutors", 0),
--- End diff --
I'm not overly concerned with this as long as its clear to the users which
way we chose. It feels like the user would use --num-executors more easily or
accidentally then specifying spark.dynamicAllocation.initialExecutors.
How about leaving it max and just print a warning if we find both set and
tell them what we choose.
I'm also not sure there is a good way to do this right now with the
ConfigEntry/Builder stuff thouh. @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
