GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/13559
Minor 3 ## What changes were proposed in this pull request? revived #13464 Fix Java Lint errors introduced by #13286 and #13280 Before: ``` Using `mvn` from path: /Users/pichu/Project/spark/build/apache-maven-3.3.9/bin/mvn Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0 Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[340,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[341,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[342,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/launcher/LauncherServer.java:[343,5] (whitespace) FileTabCharacter: Line contains a tab character. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[41,28] (naming) MethodName: Method name 'Append' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/streaming/OutputMode.java:[52,28] (naming) MethodName: Method name 'Complete' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[61,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.PrimitiveType. [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[62,8] (imports) UnusedImports: Unused import - org.apache.parquet.schema.Type. ``` ## How was this patch tested? ran `dev/lint-java` locally You can merge this pull request into a Git repository by running: $ git pull https://github.com/techaddict/spark minor-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/13559.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13559 ---- commit 40f952c204327e28f23d0d8b61beb50504c81ff7 Author: Sandeep Singh <sand...@techaddict.me> Date: 2016-06-02T10:03:24Z remove unused imports commit 1e96f6b47f5505d2d3b444ab1d0fce79b21ecc10 Author: Sandeep Singh <sand...@techaddict.me> Date: 2016-06-03T10:06:39Z suppress MethodName warning commit 762f58bd8981a7370e87c852870cf99f426829f5 Author: Sandeep Singh <sand...@techaddict.me> Date: 2016-06-03T10:12:25Z Merge branch 'master' into minor-2 commit cc7804fd9bbac8bd2d2ba3ec68cde7e86f62c2e0 Author: Sandeep Singh <sand...@techaddict.me> Date: 2016-06-08T09:58:34Z Merge branch 'master' into minor-3 commit 80ddcb41960ffa96056cc861341acb061bd3713d Author: Sandeep Singh <sand...@techaddict.me> Date: 2016-06-08T10:02:15Z fix (whitespace) FileTabCharacter: Line contains a tab character. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org