Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13552#discussion_r66289491
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -353,7 +353,7 @@ private[yarn] class YarnAllocator(
} else if (missing < 0) {
val numToCancel = math.min(numPendingAllocate, -missing)
- logInfo(s"Canceling requests for $numToCancel executor containers")
+ logInfo(s"Canceled requests for $numToCancel executor container(s)")
--- End diff --
The first message implies "I need to cancel 5". The second message says
"I'm canceling 5". There is no third message that says "I cancelled 5". I don't
think the second message is wrong, yes. But you could try to add that third
message where appropriate. Or expand the first message to be clearer about the
before and after values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
