Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/13565#discussion_r66319649
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -228,6 +232,9 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with Timeou
override def afterEach(): Unit = {
try {
scheduler.stop()
+ dagEventProcessLoopTester.stop()
+ mapOutputTracker.stop()
+ broadcastManager.stop()
--- End diff --
`broadcastManager` actually isn't leaking any threads given the current
implemenation of `TorrentBroadcastFactory`, but still we should probably stop
it. Also worth noting that netty does *not* clean up the threads for the
shuffle server and client immediately, so those still linger on between tests
for a little while, but they do get cleaned up eventually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
