Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13549#discussion_r66361438
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
 ---
    @@ -189,9 +189,20 @@ class UnsupportedOperationsSuite extends SparkFunSuite 
{
         _.intersect(_),
         streamStreamSupported = false)
     
    -  // Unary operations
    +  // Sort: supported only on batch subplans and on aggregation + complete 
output mode
       testUnaryOperatorInStreamingPlan("sort", Sort(Nil, true, _))
       testUnaryOperatorInStreamingPlan("sort partitions", SortPartitions(Nil, 
_), expectedMsg = "sort")
    +  assertSupportedInStreamingPlan(
    +    "sort - sort over aggregated data in Complete output mode",
    +    Sort(Nil, true, Aggregate(Nil, aggExprs("c"), streamRelation)),
    --- End diff --
    
    I think these would be easier to read written with the DSL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to