Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13563#discussion_r66383126
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala ---
    @@ -129,7 +130,7 @@ private[spark] class PipedRDD[T: ClassTag](
           override def run(): Unit = {
             val err = proc.getErrorStream
             try {
    -          for (line <- Source.fromInputStream(err).getLines) {
    +          for (line <- 
Source.fromInputStream(err)(StandardCharsets.UTF_8).getLines) {
    --- End diff --
    
    
    @zsxwing : I don't agree that using system default encoding would be a good 
idea. One can see different result on different systems which would be 
annoying. A user can run a binary in pipe() operator and let its stderr stream 
emit data with a character encoding that he/she wishes to.
    
    @srowen : I agree that UTF-8 is a safer default. Making this configurable 
would be the ideal thing to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to