Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1507#discussion_r15972438
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -81,11 +83,26 @@ class TaskMetrics extends Serializable {
var inputMetrics: Option[InputMetrics] = None
/**
- * If this task reads from shuffle output, metrics on getting shuffle
data will be collected here
+ * If this task reads from shuffle output, metrics on getting shuffle
data will be collected here.
+ * This includes read metrics aggregated over all the task's shuffle
dependencies.
*/
private var _shuffleReadMetrics: Option[ShuffleReadMetrics] = None
- def shuffleReadMetrics = _shuffleReadMetrics
+ def shuffleReadMetrics() = _shuffleReadMetrics
--- End diff --
nit: since this doesn't mutate internal state the original lack of
parentheses is correct style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
