Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13594#discussion_r66583343
  
    --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
    @@ -415,15 +415,20 @@ class DoubleAccumulator extends 
AccumulatorV2[jl.Double, jl.Double] {
     }
     
     
    -class ListAccumulator[T] extends AccumulatorV2[T, java.util.List[T]] {
    +/**
    + * An [[AccumulatorV2 accumulator]] for collecting a list of elements.
    + *
    + * @since 2.0.0
    + */
    +class CollectionAccumulator[T] extends AccumulatorV2[T, java.util.List[T]] 
{
    --- End diff --
    
    Question: so this method still accumulates a list, despite its name (which 
does sound better). Can an accumulator guarantee an order to the items add to 
the list meaningfully? if not, then maybe it should be advertised as an 
accumulator of a Collection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to