Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13562#discussion_r66641656
--- Diff: dev/make-distribution.sh ---
@@ -150,7 +156,13 @@ export MAVEN_OPTS="${MAVEN_OPTS:--Xmx2g
-XX:MaxPermSize=512M -XX:ReservedCodeCac
# Store the command as an array because $MVN variable might have spaces in
it.
# Normal quoting tricks don't work.
# See: http://mywiki.wooledge.org/BashFAQ/050
-BUILD_COMMAND=("$MVN" clean package -DskipTests $@)
+
+# If NUM_THREADS is set we actually want to add the -T in (removed with
shift earlier)
+if [ -n "$NUM_THREADS" ]; then
+ MVN_T_OPTION="-T"
+fi
+
+BUILD_COMMAND=("$MVN" $MVN_T_OPTION $NUM_THREADS clean package -DskipTests
$@)
--- End diff --
OK I see. Originally I figured, hey, just always set this to `-T 1C` right
here. It doesn't hurt, but also this is a rare thing, to prepare releases. I am
not sure it's worth any non-trivial complexity here. What else do we want to
plumb through then, etc. I'd either not do this, or hard-code the argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
