Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/13603#discussion_r66647379
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/BlacklistIntegrationSuite.scala
---
@@ -93,6 +94,30 @@ class BlacklistIntegrationSuite extends
SchedulerIntegrationSuite[MultiExecutorM
assertDataStructuresEmpty(noFailure = true)
}
+ // Make sure that if we've failed on all executors, but haven't hit
task.maxFailures yet, the job
+ // doesn't hang
+ testScheduler(
+ "SPARK-15865 Progress with fewer executors than maxTaskFailures",
--- End diff --
I'm pretty sure the previous flakiness in this test suite is unrelated to
the test I'm adding here, but we should probably wait to merge this until after
https://github.com/apache/spark/pull/13565 just to be safe. (at least, its
unrelated to the delay-scheduling-revive-offers issue, which was the major
previous flakiness -- potentially still suffers from the DAGScheduler /
assertDataStructuresEmpty race, but that is quite rare.) I did run this test
5K times on my laptop and it passed (though that hasn't always been enough to
discover some of the races).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
