Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/12313
@yhuai, whatever release you want to target is fine with me, but I don't
think we should block this on a design doc for cleaning up the
`DataFrameWriter`. I'm all for writing one and I plan to participate in that
design, but the scope of that work is quite a bit larger than what this PR does.
Since this PR doesn't change the public API, I don't think we should wait
until we have a plan for the public API (design doc goal 1) to commit it.
Similarly for the second goal, missing columns, extra columns, and metastore
updates are beyond the scope here, when this can simply require that the number
of columns matches since that's the most conservative strategy (that's what is
now implemented).
The remaining issue is whether it is a good idea to include the by-name
code. I think the concern is that it may change based on the API design doc,
but that's really unlikely. For example, adding the option to `InsertIntoTable`
will be required unless we duplicate that logical node, which I think is an
unlikely choice.
I'm just trying to avoid dragging this out for a lot longer, or the work of
splitting it up needlessly and having to keep rebasing the changes on master. I
could be wrong, so if I'm missing something here, then please let me know (and
thanks for being patient).
Also, I addressed @cloud-fan's comments and rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
