Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1816#issuecomment-51561557
Oh man - this is epic! @nchammas for the various environment variables, we
get them from the github pull request builder. The relevant source code is here
(btw - it would be good to put this in a comment in the bash script):
https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java#L139
I am not 100% sure on this, but my assumption is that $sha1 refers to the
thing that is currently being tested and $ghprbActualCommit refers to the head
of the topic branch. So in some cases $sha1 will be a merge commit that is
merged with the master branch. If that is the case I think we'd want to put
$ghprbActualCommit as the commit - which you've done here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
