Github user yangw1234 commented on the issue:

    https://github.com/apache/spark/pull/13585
  
    Hi @liancheng , CNF is truly a more systematic way to deal with this 
problem. 
    
    Not really sure I am right or not, but I think as long as we push the `not` 
operator down to the lowest level of the expression tree, the approach proposed 
by @chenghao-intel will work. Take the above example, expression `!(partition = 
1 && a > 3)` will be transformed to `(!(partition = 1)) || (! (a > 3))`, and 
according to the second example given by @chenghao-intel in the doc, the 
expression should be dropped entirely, so `partition = 1` will not be pruned. 
(But this rule is not appeared in the code, maybe he is working in progress to 
implemented this rule. I don't know for sure.) 
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to