Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1813#issuecomment-51564110
Hey so after thinking about it a bit more, maybe it's worth experimenting
with this simpler approach of in-lining the shaded dependency in our jars using
build plug-ins. The main reason I think it's worth trying is that, in the worst
case, if this has some random unintended consequence we can just revert to our
existing method of publishing fully shaded dependencies to maven central.
One thought for @vanzin and @srowen - what if instead of having our own
copy of Optional, we just continue advertise a full compile dependency on guava
and we get Optional from that. As long as Optional does not change. Then
basically we have a "public" use of Gauva which is for this Optional class and
a "private" use of Guava which we shade away. I think that will work as long as
Optional does not change in guava... but that is the exact scenario in which
the current approach works as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
