Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13413#discussion_r66729858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -89,6 +89,10 @@ class SimpleFunctionRegistry extends FunctionRegistry {
functionBuilders.iterator.map(_._1).toList.sorted
}
+ private[catalyst] def functionSet(): Set[String] = synchronized {
+ functionBuilders.iterator.map(_._1).toSet
--- End diff --
Seems we are still creating the set every time when we call
`FunctionRegistry.builtin.functionSet`. Can you create this set in the object
of `FunctionRegistry`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
