Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13496#discussion_r66729871
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -452,6 +452,17 @@ class Analyzer(
     
         def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
           case i @ InsertIntoTable(u: UnresolvedRelation, parts, child, _, _) 
if child.resolved =>
    +        // A partitioned relation's schema can be different from the input 
logicalPlan, since
    +        // partition columns are all moved after data columns. We Project 
to adjust the ordering.
    +        val input = if (parts.nonEmpty) {
    +          val (inputPartCols, inputDataCols) = child.output.partition { 
attr =>
    +            parts.contains(attr.name)
    +          }
    +          Project(inputDataCols ++ inputPartCols, child)
    +        } else {
    +          child
    +        }
    --- End diff --
    
    If we use the name based resolution, we also need to check if the all the 
input columns have the expected partitioning names; Otherwise, the result will 
be not predictable. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to