Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/13338#discussion_r66793258
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2262,21 +2262,39 @@ private[spark] object Utils extends Logging {
}
/**
- * Return whether dynamic allocation is enabled in the given conf
- * Dynamic allocation and explicitly setting the number of executors are
inherently
- * incompatible. In environments where dynamic allocation is turned on
by default,
- * the latter should override the former (SPARK-9092).
+ * Return whether dynamic allocation is enabled in the given conf.
*/
def isDynamicAllocationEnabled(conf: SparkConf): Boolean = {
- val numExecutor = conf.getInt("spark.executor.instances", 0)
val dynamicAllocationEnabled =
conf.getBoolean("spark.dynamicAllocation.enabled", false)
- if (numExecutor != 0 && dynamicAllocationEnabled) {
- logWarning("Dynamic Allocation and num executors both set, thus
dynamic allocation disabled.")
- }
- numExecutor == 0 && dynamicAllocationEnabled &&
+ dynamicAllocationEnabled &&
(!isLocalMaster(conf) ||
conf.getBoolean("spark.dynamicAllocation.testing", false))
}
+ /**
+ * Return the minimum number of executors for dynamic allocation.
+ */
+ def getDynamicAllocationMinExecutors(conf: SparkConf): Int = {
+ conf.getInt("spark.dynamicAllocation.minExecutors", 0)
+ }
+
+ /**
+ * Return the maximum number of executors for dynamic allocation.
+ */
+ def getDynamicAllocationMaxExecutors(conf: SparkConf): Int = {
+ conf.getInt("spark.dynamicAllocation.maxExecutors", Integer.MAX_VALUE)
+ }
+
+ /**
+ * Return the initial number of executors for dynamic allocation.
+ */
+ def getDynamicAllocationInitialExecutors(conf: SparkConf): Int = {
+ math.max(
+ math.max(
+ conf.getInt("spark.dynamicAllocation.initialExecutors", 0),
--- End diff --
I'm fine with max and as I mentioned I agree that I think users might use
or accidentally use --num-executors to bump up the value. Although I'd rather
not encourage that behavior because its intermixing these things and
--num-executors is ambiguous on the behavior (based on the dynamic allocation
on or off), which is why I suggested the warning. The warning was also in case
someone specified --num-executors and thought they were getting static number
but instead had dynamic allocation on so its initial.
I would also be fine with just an info message here printing what
allocation method we are using and the number chosen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
