Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13611#discussion_r66856578
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
    @@ -41,9 +43,22 @@ private[sql] class SharedState(val sparkContext: 
SparkContext) {
       val listener: SQLListener = createListenerAndUI(sparkContext)
     
       /**
    +   * The base hadoop configuration which is shared among all spark 
sessions. It is based on the
    +   * default hadoop configuration of Spark, with custom configurations 
inside `hive-site.xml`.
    +   */
    +  lazy val hadoopConf: Configuration = {
    +    val conf = sparkContext.hadoopConfiguration
    --- End diff --
    
    Sorry. I missed this part. Can we create a new `Configuration` instead of 
calling `addResource` directly? So, this PR will not change the behavior of 
other components which use `sparkContext.hadoopConfiguration`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to