Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13563#discussion_r66931702
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala ---
    @@ -60,8 +61,7 @@ private[spark] class PipedRDD[T: ClassTag](
           printRDDElement: (T, String => Unit) => Unit = null,
           separateWorkingDir: Boolean = false) =
         this(prev, PipedRDD.tokenize(command), envVars, printPipeContext, 
printRDDElement,
    -      separateWorkingDir, 8192)
    -
    +      separateWorkingDir, 8192, Codec.defaultCharsetCodec.name)
    --- End diff --
    
    I think we can remove this whole constructor actually. I don't see it is 
used anywhere and it's internal. It might help keep this a little simpler, if 
so. (The comment above it at least looks unrelated.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to