Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13636#discussion_r67019739
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -19,21 +19,25 @@ context("test functions in sparkR.R")
test_that("Check masked functions", {
# Check that we are not masking any new function from base, stats,
testthat unexpectedly
- masked <- conflicts(detail = TRUE)$`package:SparkR`
- expect_true("describe" %in% masked) # only when with testthat..
- func <- lapply(masked, function(x) { capture.output(showMethods(x))[[1]]
})
- funcSparkROrEmpty <- grepl("\\(package SparkR\\)$|^$", func)
- maskedBySparkR <- masked[funcSparkROrEmpty]
+ # This list should not change!
--- End diff --
just want to make sure people are aware that this list of names shouldn't
be added to without considering what it means? if there's a better way to
convey that let me know?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
