Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13684#discussion_r67208357
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1869,6 +1869,7 @@ setMethod("where",
     #' path <- "path/to/file.json"
     #' df <- read.json(path)
     #' dropDuplicates(df)
    +#' dropDuplicates(df, "col1", "col2")
     #' dropDuplicates(df, c("col1", "col2"))
     #' }
     setMethod("dropDuplicates",
    --- End diff --
    
    Since we have unified the generics, can we also fold this method into the 
other one ? i.e. move the code here to the `length(col) > 1` case in the other 
function 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to