Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1252#discussion_r16015725
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -96,8 +94,8 @@ private[ui] class RDDPage(parent: StorageTab) extends
WebUIPage("rdd") {
</div>
</div>;
- UIUtils.headerSparkPage(content, basePath, appName, "RDD Storage Info
for " + rddInfo.name,
- parent.headerTabs, parent)
+ UIUtils.headerSparkPage(content, parent.getBasePath(),
parent.getAppName(),
+ "RDD Storage Info for " + rddInfo.name, parent.headerTabs, parent)
--- End diff --
I just noticed we're passing in many of `parent`'s fields in addition to
`parent`, which seems unnecessary. Maybe add a helper method that takes in a
`SparkUITab` that abstracts this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
