Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1862#discussion_r16023042
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
---
@@ -76,22 +76,34 @@ class LogisticRegressionSuite extends FunSuite with
LocalSparkContext with Match
val testRDD = sc.parallelize(testData, 2)
testRDD.cache()
- val lr = new LogisticRegressionWithSGD().setIntercept(true)
- lr.optimizer.setStepSize(10.0).setNumIterations(20)
- val model = lr.run(testRDD)
+ val lrWithSGD = new LogisticRegressionWithSGD().setIntercept(true)
+ lrWithSGD.optimizer.setStepSize(10.0).setNumIterations(20)
+
+ val lrWithLBFGS = new LogisticRegressionWithLBFGS().setIntercept(true)
+
+ val modelWithSGD = lrWithSGD.run(testRDD)
+ val modelWithLBFGS = lrWithLBFGS.run(testRDD)
--- End diff --
For the unit tests. It might be better if we separate LBFGS tests from SGD
tests since they are different units.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
