GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/13725

    [SPARK-15892][ML] Backport correctly merging AFTAggregators to branch 1.6

    ## What changes were proposed in this pull request?
    
    This PR backports https://github.com/apache/spark/pull/13619.
    
    The original test added in branch-2.0 was failed in branch-1.6.
    
    This seems because the behaviour was changed in 
https://github.com/apache/spark/commit/101663f1ae222a919fc40510aa4f2bad22d1be6f.
 This was failure while calculating Euler's number which ends up with a 
infinity regardless of this path.
    
    So, I brought the dataset from `AFTSurvivalRegressionExample` to make sure 
this is working and then wrote the test.
    
    I ran the test before/after creating empty partitions. `model.scale` 
becomes `1.0` with empty partitions and becames `1.547` without them.
    
    After this patch, this becomes always `1.547`.
    
    
    ## How was this patch tested?
    
    Unit test in `AFTSurvivalRegressionSuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-15892-1-6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13725
    
----
commit c42cc51e25bf8b88aac08bec3c1f636b5d1a8a3a
Author: hyukjinkwon <gurwls...@gmail.com>
Date:   2016-06-16T11:09:19Z

    Backport correctly merging AFTAggregator to branch 1.6

commit b0203fcaeeb865bfe21bfff0475fa1be50c4f5ba
Author: hyukjinkwon <gurwls...@gmail.com>
Date:   2016-06-17T01:13:56Z

    Update comments

commit 9cf8152c6121faa37a9cd337fddfa22f1457fc43
Author: hyukjinkwon <gurwls...@gmail.com>
Date:   2016-06-17T01:24:51Z

    Fix coment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to