Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13729#discussion_r67480295
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -990,11 +987,11 @@ private class LogisticAggregator(
var sum = 0.0
features.foreachActive { (index, value) =>
if (featuresStd(index) != 0.0 && value != 0.0) {
- sum += localCoefficientsArray(index) * (value /
featuresStd(index))
+ sum += coefficientsArray(index) * (value /
featuresStd(index))
--- End diff --
I could be missing something, but why are the values being normalized by
the stdev but not centered by the mean? before, the means were passed in, so I
wonder if something was being overlooked before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
