Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13754#discussion_r67597343
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
 ---
    @@ -348,6 +348,7 @@ abstract class HiveComparisonTest
                     queryString.replace("../../data", testDataPath))
                   val containsCommands = originalQuery.analyzed.collectFirst {
                     case _: Command => ()
    +                case _: InsertIntoTable => ()
    --- End diff --
    
    ah, it's because I removed the `PreInsertionCasts` rule, which turns 
`InsertIntoTable` to `InsertIntoHiveTable`. This conversion doesn't matter, as 
hive planner will plan `InsertIntoTable` into physical `InsertIntoHiveTable`.
    
    So adding a case here is a reasonable fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to