Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13140#discussion_r67605281
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1769,7 +1769,10 @@ class Dataset[T] private[sql](
* @since 2.0.0
*/
def dropDuplicates(colNames: Seq[String]): Dataset[T] = withTypedPlan {
- val groupCols = colNames.map(resolve)
+ val groupCols = colNames.map {
+ case column if column.contains(".") && !column.contains("`") =>
s"`$column`"
--- End diff --
Actually we do have a lot of places that trying to resolve column name
without parsing it, e.g. `withColumn`, `drop`. We can abstract the logic into a
method and call it instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
