Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1864#discussion_r16027127
--- Diff: python/pyspark/java_gateway.py ---
@@ -39,7 +39,7 @@ def launch_gateway():
submit_args = os.environ.get("PYSPARK_SUBMIT_ARGS")
submit_args = submit_args if submit_args is not None else ""
submit_args = shlex.split(submit_args)
- command = [os.path.join(SPARK_HOME, script), "pyspark-shell"] +
submit_args
+ command = [os.path.join(SPARK_HOME, script)] + submit_args +
["pyspark-shell"]
--- End diff --
@liancheng Yes, `bin/pyspark` with a python file doesn't go down here, but
this code path is mainly for the pyspark shell, where the user my specify
ipython with arguments, e.g. `notebook` or `--py-lab`. In this case we need to
put these application arguments after `pyspark-shell`, otherwise these
arguments are never handled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
