GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/13776
[SPARK-16050][Tests]Remove the flaky test: ConsoleSinkSuite
## What changes were proposed in this pull request?
ConsoleSinkSuite just collects content from stdout and compare them with
the expected string. However, because Spark may not stop some background
threads at once, there is a race condition that other threads are outputting
logs while ConsoleSinkSuite is running. Then it will make ConsoleSinkSuite fail.
Therefore, I just deleted `ConsoleSinkSuite`. If we want to test
ConsoleSinkSuite in future, we should refactoring ConsoleSink to make it
testable instead of depending on stdout,
## How was this patch tested?
Just removed a flaky test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-16050
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13776
----
commit 6e136ff97ee47838cd15137f85747d61d2e148b2
Author: Shixiong Zhu <shixi...@databricks.com>
Date: 2016-06-20T03:42:05Z
Remove the flaky test: ConsoleSinkSuite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
