Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r67634511 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -590,6 +592,53 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder { } /** + * Create a [[CreateMacroCommand]] command. + * + * For example: + * {{{ + * CREATE TEMPORARY MACRO macro_name([col_name col_type, ...]) expression; + * }}} + */ + override def visitCreateMacro(ctx: CreateMacroContext): LogicalPlan = withOrigin(ctx) { + val arguments = Option(ctx.colTypeList).map(visitColTypeList(_)) + .getOrElse(Seq.empty[StructField]).map { col => + AttributeReference(col.name, col.dataType, col.nullable, col.metadata)() } + val colToIndex: Map[String, Int] = arguments.map(_.name).zipWithIndex.toMap --- End diff -- Why i do not to move this into the CreateMacroCommand? Because analyzer.checkAnalysis() will check if macroFunction of CreateMacroCommand is invalid. macroFunction has UnresolvedAttributes, So analyzer.checkAnalysis() will throw a unresolved exception. If it resolved UnresolvedAttributes before, analyzer.checkAnalysis() does not throw a exception.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org