Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13718#discussion_r67736121
--- Diff: core/src/main/scala/org/apache/spark/util/ManualClock.scala ---
@@ -57,9 +59,19 @@ private[spark] class ManualClock(private var time: Long)
extends Clock {
* @return current time reported by the clock when waiting finishes
*/
def waitTillTime(targetTime: Long): Long = synchronized {
- while (time < targetTime) {
- wait(10)
+ _isWaiting = true
+ try {
+ while (time < targetTime) {
+ wait(10)
+ }
+ getTimeMillis()
+ } finally {
+ _isWaiting = false
}
- getTimeMillis()
}
+
+ /**
+ * Returns whether there is any thread being blocked in `waitTillTime`.
+ */
+ def isWaiting: Boolean = synchronized { _isWaiting }
--- End diff --
`wait(10)` in `waitTillTime` will give up the lock.
`wait`'s javadoc:
> This method causes the current thread (call it T) to place itself in the
wait set for this object and then to relinquish any and all synchronization
claims on this object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
