Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1823#discussion_r16028389
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala ---
@@ -132,9 +132,12 @@ object BlockFetcherIterator {
}
case Failure(exception) => {
logError("Could not get block(s) from " + cmId, exception)
- for ((blockId, size) <- req.blocks) {
- results.put(new FetchResult(blockId, -1, null))
- }
+ /**
+ * In current implementation, only pass the first element is
enough
+ * because when iterator get FetchResult which size is -1,
+ * FetchFailedException is thrown immediately.
+ */
+ results.put(new FetchResult(req.blocks(0)._1, -1, null))
--- End diff --
Changing this seems somewhat brittle... what if we want to change the
behavior on the receiving end? These results are very small, I don't see a big
problem with sending them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
