Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13773#discussion_r67754085
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -52,29 +52,42 @@ private[sql] object JDBCRelation {
* @return an array of partitions with where clause for each partition
*/
def columnPartition(partitioning: JDBCPartitioningInfo):
Array[Partition] = {
- if (partitioning == null) return Array[Partition](JDBCPartition(null,
0))
+ if (partitioning == null || partitioning.numPartitions <= 1 ||
+ partitioning.lowerBound == partitioning.upperBound) {
+ return Array[Partition](JDBCPartition(null, 0))
+ }
+
+ val lowerBound = partitioning.lowerBound
+ val upperBound = partitioning.upperBound
+ require (lowerBound <= upperBound,
+ "Operation not allowed: the lower bound of partitioning column is
larger than the upper " +
+ s"bound. lowerBound: $lowerBound; higherBound: $upperBound")
- val numPartitions = partitioning.numPartitions
+ val numPartitions =
+ if ((upperBound - lowerBound) >= partitioning.numPartitions) {
+ partitioning.numPartitions
+ } else {
+ upperBound - lowerBound
+ }
val column = partitioning.column
- if (numPartitions == 1) return Array[Partition](JDBCPartition(null, 0))
// Overflow and silliness can happen if you subtract then divide.
// Here we get a little roundoff, but that's (hopefully) OK.
- val stride: Long = (partitioning.upperBound / numPartitions
- - partitioning.lowerBound / numPartitions)
+ val stride: Long = upperBound / numPartitions - lowerBound /
numPartitions
+ assert(stride >= 1)
--- End diff --
Will do it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
